CVE-2022-21696

Description

Between September 26, 2021 and October 8, 2021, [Radically Open Security](https://www.radicallyopensecurity.com/) conducted a penetration test of OnionShare 2.4, funded by the Open Technology Fund's [Red Team lab](https://www.opentech.fund/labs/red-team-lab/). This is an issue from that penetration test. - Vulnerability ID: OTF-005 - Vulnerability type: Improper Input Sanitization - Threat level: Low ## Description: It is possible to change the username to that of another chat participant with an additional space character at the end of the name string. ## Technical description: Assumed users in Chat: - Alice - Bob - Mallory 1. Mallory renames to `Alice `. 2. Mallory sends message as `Alice `. 3. Alice and Bob receive a message from Mallory disguised as `Alice `, which is hard to distinguish from the `Alice` in the web interface.   Other (invisible) whitespace characters were found to be working as well. ## Impact: An adversary with access to the chat environment can use the rename feature to impersonate other participants by adding whitespace characters at the end of the username. ## Recommendation: - Remove non-visible characters from the username

Affected packages (3)

• Debian/onionsharefrom 0, < 2.5-1
• PyPI/onionshare-cli>= 2.3, < 2.5
• PyPI/onionshare-clifrom 0, < 2.5

CVSS scores

References (6)

• ADVISORYhttps://nvd.nist.gov/vuln/detail/CVE-2022-21696
• ADVISORYhttps://security-tracker.debian.org/tracker/CVE-2022-21696
• PATCHhttps://github.com/onionshare/onionshare
• WEBhttps://github.com/onionshare/onionshare/releases/tag/v2.5
• WEBhttps://github.com/onionshare/onionshare/security/advisories/GHSA-68vr-8f46-vc9f
• WEBhttps://github.com/pypa/advisory-database/tree/main/vulns/onionshare-cli/PYSEC-2022-47.yaml